Fix inconsistent usage of prepared statement name in PostgresClient #613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #613 +/- ##
==========================================
+ Coverage 75.88% 76.11% +0.22%
==========================================
Files 134 134
Lines 10098 10098
==========================================
+ Hits 7663 7686 +23
+ Misses 2435 2412 -23
🚀 New features to boost your workflow:
|
sidepelican
force-pushed
the
prepared_statement_name
branch
from
cb1fa2b to
0a966bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PostgresClientwas usingString(reflecting: Statement.self)to determine the name of a prepared statement instead of using the protocol-definedPostgresPreparedStatement.name.Other parts of the codebase correctly utilize the
nameproperty.This PR ensures consistency by using the explicit
.nameproperty as intended.postgres-nio/Sources/PostgresNIO/Connection/PostgresConnection.swift
Line 476 in 7383207